[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818658#comment-15818658
]
ASF GitHub Bot commented on THRIFT-3873:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r95604407
--- Diff: lib/cpp/src/thrift/windows/config.h ---
@@ -36,6 +36,9 @@
#define USE_BOOST_THREAD 1
#endif
+// Something that defines PRId64 is required to build
+#define HAVE_INTTYPES_H 1
+
--- End diff --
Note I have opened THRIFT-4025 because I don't see why we have a custom
config.h file on Windows when we go through the hassle of generating one with
cmake.
> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
> Key: THRIFT-3873
> URL: https://issues.apache.org/jira/browse/THRIFT-3873
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Environment: VS2010, Windows
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> While verifying a defect I had to build the windows thrift C++ library and
> found a number of compiler warnings that needed to be cleaned up. As part of
> cleaning these up, I found that additional compilers were also posting
> warnings.
> Acceptance Criteria:
> # I can build successfully with Visual Studio 2010 targeting x86 debug mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2010 targeting x86 release mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2010 targeting x64 debug mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2010 targeting x64 release mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x86 debug mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x86 release mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x64 debug mode
> with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x64 release mode
> with /WX (warnings are errors).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
