Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r96876857
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -16,30 +16,30 @@
# specific language governing permissions and limitations
# under the License.
#
+cmake_minimum_required(VERSION 2.8.12)
+
+set(BIN_INSTALL_DIR ${CMAKE_INSTALL_PREFIX}/bin)
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/src/thrift/version.h.in
${CMAKE_CURRENT_BINARY_DIR}/thrift/version.h)
find_package(FLEX REQUIRED)
find_package(BISON REQUIRED)
# Create flex and bison files and build the lib parse static library
-BISON_TARGET(thrifty ${CMAKE_CURRENT_SOURCE_DIR}/src/thrift/thrifty.yy
${CMAKE_CURRENT_BINARY_DIR}/thrift/thrifty.cc)
+BISON_TARGET(thrifty
+ ${CMAKE_CURRENT_SOURCE_DIR}/src/thrift/thrifty.yy
+ ${CMAKE_CURRENT_BINARY_DIR}/thrift/thrifty.cc
+ DEFINES_FILE ${CMAKE_CURRENT_BINARY_DIR}/thrift/thrifty.h)
--- End diff --
Nice addition of DEFINES_FILE so rebuilds are not triggered - I was
wondering why successive build runs would rebuild the compiler - this is
probably one fix for such a case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
