Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r97247885
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -53,6 +53,7 @@ set(compiler_core
set(thrift-compiler_SOURCES
src/thrift/main.cc
src/thrift/audit/t_audit.cpp
+ ${compiler_core}
--- End diff --
This will still break the thrift compiler plug-in module support, won't it?
The compiler_core modules must be conditionally added depending on the
WITH_PLUGIN setting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
