[
https://issues.apache.org/jira/browse/THRIFT-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833460#comment-15833460
]
ASF GitHub Bot commented on THRIFT-4038:
----------------------------------------
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1153
Tracked in THRIFT-4038
@GZShi: next time please have a look at our [contrib
guidelines](http://thrift.apache.org/docs/HowToContribute)
> socket check: checking an unsigned number against >= 0 never fails
> ------------------------------------------------------------------
>
> Key: THRIFT-4038
> URL: https://issues.apache.org/jira/browse/THRIFT-4038
> Project: Thrift
> Issue Type: Bug
> Environment: Windows
> Reporter: Jens Geyer
>
> The SOCKET type is defined as a unsigned number in windows, the
> evutil_socket_t variables are always large than zero, therefore the
> condition not work well here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
