[
https://issues.apache.org/jira/browse/THRIFT-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833485#comment-15833485
]
Jens Geyer commented on THRIFT-4038:
------------------------------------
fix a bug in windows
The `SOCKET` type is defined as a unsigned number in windows, the
`evutil_socket_t` variables are always large than zero, therefore the condition
not work well here.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GZShi/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1153
----
commit 46d73d3d0e0819d6d95805f4b228e3e3c8408082
Author: gzshi <[email protected]>
Date: 2017-01-06T02:47:03Z
fix a bug in windows
The `SOCKET` type is defined as a unsigned number in windows, the
`evutil_socket_t` variables are always large than zero, therefore the condition
not work well here.
----
> socket check: checking an unsigned number against >= 0 never fails
> ------------------------------------------------------------------
>
> Key: THRIFT-4038
> URL: https://issues.apache.org/jira/browse/THRIFT-4038
> Project: Thrift
> Issue Type: Bug
> Environment: Windows
> Reporter: Jens Geyer
>
> The SOCKET type is defined as a unsigned number in windows, the
> evutil_socket_t variables are always large than zero, therefore the
> condition not work well here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
