[ 
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868530#comment-15868530
 ] 

ASF GitHub Bot commented on THRIFT-4064:
----------------------------------------

Github user zertosh commented on the issue:

    https://github.com/apache/thrift/pull/1175
  
    @bgould that's a very similar use case to ours. Also the Q library is kinda 
heavy, and could probably switch to just using native Promises.
    
    For the purposes of this PR (avoid binary deps), I just switched to [email protected] 
instead of [email protected], so that phantomjs doesn't choke. We'll still have some lib 
duplication, but at least you don't need to compile the dep.


> Update node library dependencies
> --------------------------------
>
>                 Key: THRIFT-4064
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4064
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>    Affects Versions: 0.10.0
>            Reporter: Andres Suarez
>            Assignee: James E. King, III
>
> [email protected] is really old and presents issues for users using modern versions 
> of Node (see 
> https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should 
> be updated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to