[
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868634#comment-15868634
]
ASF GitHub Bot commented on THRIFT-4064:
----------------------------------------
Github user zertosh commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1175#discussion_r101392209
--- Diff: build/docker/debian/Dockerfile ---
@@ -113,8 +113,8 @@ RUN apt-get update && apt-get install -y
--no-install-recommends \
neko-dev \
libneko0
-# Node.js dependencies - THRIFT-4064 says it must be >= 4.x
-RUN curl -sL https://deb.nodesource.com/setup_4.x | bash -
+# Node.js dependencies - THRIFT-4064 says it must be >= 0.12.0
--- End diff --
The point was to move away from `ws@<1.0.0`, since those versions depend on
native node modules - they're a huge pain
(https://github.com/apache/thrift/pull/672#issuecomment-276678791). Ideally
we'd upgrade to the latest `ws` (v2.x), but the newer JS syntax is proving to
be really problematic. Less ideally, but nonetheless solves the native module
problem, is to upgrade to `ws@^1.0.0`. That only requires Node >= 0.12.0, and
doesn't use newer syntax.
I still want to use `ws@^2.0.0`, but that requires other upstream dep
fixes. I'm not really familiar with phantomjs, so that's going to take me a bit.
> Update node library dependencies
> --------------------------------
>
> Key: THRIFT-4064
> URL: https://issues.apache.org/jira/browse/THRIFT-4064
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.10.0
> Reporter: Andres Suarez
> Assignee: James E. King, III
>
> [email protected] is really old and presents issues for users using modern versions
> of Node (see
> https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should
> be updated.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
