ASF GitHub Bot commented on THRIFT-4279:

Github user djnym commented on the issue:

    @Jens-G this probably needs to be merged assuming it passes the checks as 
we don't want to generate bad code.  

> Wrong path in include directive in generated Thrift sources
> -----------------------------------------------------------
>                 Key: THRIFT-4279
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4279
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Compiler
>            Reporter: David Hull
>            Priority: Minor
> My code change in THRIFT-4270 introduced a bug in the path to the generated 
> header files in the generated Erlang code. Previously the `-include` 
> directives did not specify a path, but after the THRIFT-4270 change the 
> `-include` directive has the "gen-erl" directory as part of the path.
> Example include directive before the change:
> {noformat}
> -include("constants_demo_types.hrl").
> {noformat}
> Example include directive after the change:
> {noformat}
> -include("test/gen-erl/constants_demo_types.hrl").
> {noformat}

This message was sent by Atlassian JIRA

Reply via email to