[ 
https://issues.apache.org/jira/browse/THRIFT-4279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119008#comment-16119008
 ] 

ASF GitHub Bot commented on THRIFT-4279:
----------------------------------------

GitHub user dhull opened a pull request:

    https://github.com/apache/thrift/pull/1329

    THRIFT-4279: Fix include path in generated Erlang Thrift sources.

    The change in THRIFT-4270 inadvertantly modified the include directives in 
the generated Erlang sources to include the gen-erl directory in the path to 
the include file.  This commit restores the
    previous behavior.
    
    Example include directive before the THRIFT-4270 change:
    ```erlang
    -include("constants_demo_types.hrl").
    ```
    
    Example include directive after the THRIFT-4270 change:
    ```erlang
    -include("test/gen-erl/constants_demo_types.hrl").
    ```


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhull/thrift 
thrift-4279-erlang-fix-include-path

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1329.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1329
    
----
commit 4aa8fca3955ff6eb1f6cc810a8cad50a74294caa
Author: David Hull <david.h...@openx.com>
Date:   2017-08-08T17:42:37Z

    THRIFT-4279: Fix include path in generated Erlang Thrift sources.
    
    The change in THRIFT-4270 inadvertantly modified the include
    directives in the generated Erlang sources to include the gen-erl
    directory in the path to the include file.  This commit restores the
    previous behavior.

----


> Wrong path in include directive in generated Thrift sources
> -----------------------------------------------------------
>
>                 Key: THRIFT-4279
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4279
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Compiler
>            Reporter: David Hull
>            Priority: Minor
>
> My code change in THRIFT-4270 introduced a bug in the path to the generated 
> header files in the generated Erlang code. Previously the `-include` 
> directives did not specify a path, but after the THRIFT-4270 change the 
> `-include` directive has the "gen-erl" directory as part of the path.
> Example include directive before the change:
> {noformat}
> -include("constants_demo_types.hrl").
> {noformat}
> Example include directive after the change:
> {noformat}
> -include("test/gen-erl/constants_demo_types.hrl").
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to