[
https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185053#comment-16185053
]
ASF GitHub Bot commented on THRIFT-4350:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1379
THRIFT-4350: enable dotnet-2.0.0-sdk in ubuntu xenial
update netcore projects, get them running with make cross
Client: netcore
This is purely experimental. I wanted to know what was involved. I moved
everything to the latest version which may not be useful. I got netcore with
dotnet-2.0.0-sdk and netcoreapp2.0 targeted applications runnign in make cross
(as client only).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4350-dotnetcore-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1379.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1379
----
commit 592d4c73107ef06355cee438fb3e326dbb43ba0f
Author: James E. King, III <[email protected]>
Date: 2017-09-28T11:57:42Z
THRIFT-4350: enable dotnet-2.0.0-sdk in ubuntu xenial, update netcore
projects, get them running with make cross
Client: netcore
----
> Update netcore build for dotnet 2.0 sdk and make cross validation
> -----------------------------------------------------------------
>
> Key: THRIFT-4350
> URL: https://issues.apache.org/jira/browse/THRIFT-4350
> Project: Thrift
> Issue Type: Improvement
> Components: .NETCore - Library
> Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial
> Reporter: James E. King, III
> Assignee: James E. King, III
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project
> that is checked in
> # Ensure one can build on Linux using the project that is checked in and use
> make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
