[
https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239756#comment-16239756
]
ASF GitHub Bot commented on THRIFT-4350:
----------------------------------------
Github user danielcrenna commented on the issue:
https://github.com/apache/thrift/pull/1379
@jeking3 What csharp gen options are passed to produce source compatible
with this netcore lib? Any .thrift file I pass through `csharp:async` for
example uses old style begin/end but this netcore lib uses async/await
patterns, but I can't find any published reference for C# option to generate
corresponding output. Also the namespaces appear to differ. My reference point
is thrift-0.10.0.
> Update netcore build for dotnet 2.0 sdk and make cross validation
> -----------------------------------------------------------------
>
> Key: THRIFT-4350
> URL: https://issues.apache.org/jira/browse/THRIFT-4350
> Project: Thrift
> Issue Type: Improvement
> Components: .NETCore - Library
> Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial
> Reporter: James E. King, III
> Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project
> that is checked in
> # Ensure one can build on Linux using the project that is checked in and use
> make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
