[GitHub] thrift pull request #1401: THRIFT-4373: Derefer PHP zval _TSPEC

[RobberPhex]

Github user RobberPhex commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1401#discussion_r147052024
  
    --- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
    @@ -699,6 +702,9 @@ void binary_serialize_hashtable_key(int8_t keytype, 
PHPOutputTransport& transpor
     
     static
     void binary_serialize(int8_t thrift_typeID, PHPOutputTransport& transport, 
zval* value, HashTable* fieldspec) {
    +  if (value) {
    --- End diff --
    
    `Z_TYPE_P(prop) == IS_REFERENCE`


---