[GitHub] thrift pull request #1401: THRIFT-4373: Derefer PHP zval _TSPEC

[sokac]

Github user sokac commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1401#discussion_r147295629
  
    --- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
    @@ -537,6 +537,9 @@ void binary_deserialize(int8_t thrift_typeID, 
PHPInputTransport& transport, zval
           }
     
           zval* spec = zend_read_static_property(Z_OBJCE_P(return_value), 
"_TSPEC", sizeof("_TSPEC")-1, false);
    +      if (spec) {
    --- End diff --
    
    ZVAL_DEREF checks is reference:
    
https://github.com/php/php-src/blob/ffc734b2a455e2f2748f18a54ab597f7e0c715ba/Zend/zend_types.h#L944
    
    I removed if statement 


---