[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303412#comment-16303412
]
ASF GitHub Bot commented on THRIFT-4434:
----------------------------------------
GitHub user vgotra opened a pull request:
https://github.com/apache/thrift/pull/1449
THRIFT-4434. Update .NET Core components, add tests for .Net Core library
and .Net Core compiler, fix bugs and build process
This pull request should:
- highly improve the current version of .Net Core library and .Net Core
compiler and quality of code
- improve and simplify build process
- improve documentation related to .Net Core library and compiler
- fix found bugs (some of bugs can be clarified like major - they are
related to porting of protocols from Java version and can be present in C#
library)
- add important unit tests for .Net Core library and .Net Core compiler
- add possibility to easy add unit tests for compiler for other languages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vgotra/thrift netcore-standard2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1449.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1449
----
commit e3c255ff30d7aa6bcfc3fbaa5e3127698998a3d7
Author: Volodymyr Gotra <volodymyr.gotra@...>
Date: 2017-12-18T00:08:09Z
Initial merge of changes without fixes of builds
commit f6ced18b7021b72679af04b54da3019b34208a90
Author: Volodymyr Gotra <vgotra@...>
Date: 2017-12-25T03:58:12Z
Fixed code generation from thrift files (for CLI and VS), fixed other issues
commit 3ad1dd065e6b71d69d583884c441f3a9e550dc0a
Author: Volodymyr Gotra <vgotra@...>
Date: 2017-12-25T16:48:21Z
Updated build, readme, cmake files for tests
commit abc788df104ba6818fe5b9aaf13e2e5714fe791c
Author: Volodymyr Gotra <vgotra@...>
Date: 2017-12-25T17:07:38Z
Updated copyrights
commit 2cf70c58d3f3081b026a852e2ab4a391297ed06d
Author: Volodymyr Gotra <volodymyr.gotra@...>
Date: 2017-12-25T21:52:40Z
Fixes for header file, updated project files, updated Makefiles
commit f55e4d9bd085fb5a8ecbc9b228d9a233bb9c4931
Author: Volodymyr Gotra <vgotra@...>
Date: 2017-12-25T23:06:48Z
Added public interfaces generation for testing, updated readme
commit a8ad6ec61c9b6c4c56476e2bcd2aa484b4f0e298
Author: Volodymyr Gotra <vgotra@...>
Date: 2017-12-25T23:24:03Z
Updated readme
commit d1d96857a72f26f840707807393260f5fc1face5
Author: Volodymyr Gotra <volodymyr.gotra@...>
Date: 2017-12-25T23:36:50Z
Added detection of Windows platform
----
> Update .NET Core components, add tests for .Net Core library and .Net Core
> compiler, fix bugs and build process
> ---------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-4434
> URL: https://issues.apache.org/jira/browse/THRIFT-4434
> Project: Thrift
> Issue Type: Improvement
> Components: .NETCore - Compiler, .NETCore - Library, Build Process
> Environment: Windows, Linux, MacOS
> Reporter: Volodymyr Gotra
> Assignee: Volodymyr Gotra
> Priority: Critical
>
> This pull request should:
> - highly improve the current version of .Net Core library and .Net Core
> compiler and quality of code
> - improve and simplify build process
> - improve documentation related to .Net Core library and compiler
> - fix found bugs (some of bugs can be clarified like major - they are related
> to porting of protocols from Java version and can be present in C# library)
> - add important unit tests for .Net Core library and .Net Core compiler
> - add possibility to easy add unit tests for compiler for other languages
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
