[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320434#comment-16320434
]
Volodymyr Gotra commented on THRIFT-4434:
-----------------------------------------
Hey
It seem it works well now (checked logs) - almost all errors fixed, also
integration with other languages is perfect (except CSharp - I think we can
merge some changes into CSharp language later to fix compatibility and found
bugs - maybe some functionality is missing in CSharp implementation).
Please help to merge as quick as possible this pull request (to avoid problems
with merges). Also it will be a great idea to be able to apply some compiler
flags for different builds (because of C++ compilers related problems - with
one compiler we can build it easily, but another one can throw errors on usual
usage of C++ language instructions).
Also, can be great to share with people scripts to build and instruction how to
reuse environments for building to avoid usage a AppVeyor/TravisCI a lot of
times and make pull requests faster to merge (I think this can be great help
for community and will help to process pull requests faster for you).
Additional idea - to reuse CMake fully for all solution - it seems that CMake
is going to be de facto standard to reuse it with many compilers (also it
easier to modify and customize for different compilers to solution very stable
and flexible). According to news, LLVM(Clang) moved to CMake.
Thanks for help
> Update .NET Core components, add tests for .Net Core library and .Net Core
> compiler, fix bugs and build process
> ---------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-4434
> URL: https://issues.apache.org/jira/browse/THRIFT-4434
> Project: Thrift
> Issue Type: Improvement
> Components: .NETCore - Compiler, .NETCore - Library, Build Process
> Environment: Windows, Linux, MacOS
> Reporter: Volodymyr Gotra
> Assignee: Volodymyr Gotra
> Priority: Critical
>
> This pull request should:
> - highly improve the current version of .Net Core library and .Net Core
> compiler and quality of code
> - improve and simplify build process
> - improve documentation related to .Net Core library and compiler
> - fix found bugs (some of bugs can be clarified like major - they are related
> to porting of protocols from Java version and can be present in C# library)
> - add important unit tests for .Net Core library and .Net Core compiler
> - add possibility to easy add unit tests for compiler for other languages
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
