[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325174#comment-16325174
]
ASF GitHub Bot commented on THRIFT-4434:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161374818
--- Diff: test/tests.json ---
@@ -1,689 +1,686 @@
-[
--- End diff --
Here's the diff
```
diff tests.json.old.normalized tests.json.new.normalized
222a223
> "header",
440c441
< "server-disabled": {
---
> "server": {
445,446c446
< "--no-restore",
< "--",
---
> "--project=Server\/Server.csproj",
456,457c456
< "--no-restore",
< "--",
---
> "--project=Client\/Client.csproj",
461c460
< "workdir": "netcore\/ThriftTest"
---
> "workdir": "netcore"
```
> Update .NET Core components, add tests for .Net Core library and .Net Core
> compiler, fix bugs and build process
> ---------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-4434
> URL: https://issues.apache.org/jira/browse/THRIFT-4434
> Project: Thrift
> Issue Type: Improvement
> Components: .NETCore - Compiler, .NETCore - Library, Build Process
> Environment: Windows, Linux, MacOS
> Reporter: Volodymyr Gotra
> Assignee: Volodymyr Gotra
> Priority: Critical
>
> This pull request should:
> - highly improve the current version of .Net Core library and .Net Core
> compiler and quality of code
> - improve and simplify build process
> - improve documentation related to .Net Core library and compiler
> - fix found bugs (some of bugs can be clarified like major - they are related
> to porting of protocols from Java version and can be present in C# library)
> - add important unit tests for .Net Core library and .Net Core compiler
> - add possibility to easy add unit tests for compiler for other languages
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
