[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325198#comment-16325198
]
ASF GitHub Bot commented on THRIFT-4434:
----------------------------------------
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1449
I changed the lib/netcore/Makefile.am to this, maybe it's enough to do both:
```
SUBDIRS = .
all-local: \
$(DOTNETCORE) build
check-local: \
$(DOTNETCORE) test Tests\Thrift.Tests\Thrift.Tests.csproj
${DOTNETCORE} test
Tests\Thrift.IntegrationTests\Thrift.IntegrationTests.csproj
clean-local:
$(RM) -r Thrift/bin
$(RM) -r Thrift/obj
EXTRA_DIST = \
README.md \
Tests \
Thrift \
Thrift.sln \
build.cmd \
build.sh \
runtests.cmd \
runtests.sh
```
I will test locally.
> Update .NET Core components, add tests for .Net Core library and .Net Core
> compiler, fix bugs and build process
> ---------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-4434
> URL: https://issues.apache.org/jira/browse/THRIFT-4434
> Project: Thrift
> Issue Type: Improvement
> Components: .NETCore - Compiler, .NETCore - Library, Build Process
> Environment: Windows, Linux, MacOS
> Reporter: Volodymyr Gotra
> Assignee: Volodymyr Gotra
> Priority: Critical
>
> This pull request should:
> - highly improve the current version of .Net Core library and .Net Core
> compiler and quality of code
> - improve and simplify build process
> - improve documentation related to .Net Core library and compiler
> - fix found bugs (some of bugs can be clarified like major - they are related
> to porting of protocols from Java version and can be present in C# library)
> - add important unit tests for .Net Core library and .Net Core compiler
> - add possibility to easy add unit tests for compiler for other languages
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
