[
https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327186#comment-16327186
]
ASF GitHub Bot commented on THRIFT-4438:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1451#discussion_r161777001
--- Diff: build/docker/ubuntu-trusty/Dockerfile ---
@@ -1,223 +0,0 @@
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-#
-# Apache Thrift Docker build environment for Ubuntu Trusty
-# Using all stock Ubuntu Trusty packaging except for:
-# - d: does not come with Ubuntu so we're installing 2.070.0
-# - dart: does not come with Ubuntu so we're installing 1.20.1
-# - dotnetcore, disabled because netcore is for 1.0.0-preview and 2.0.0 is
out
-# - haxe, disabled because the distro comes with 3.0.0 and it cores while
installing
-# - node.js, disabled because it is at 0.10.0 in the distro which is too
old (need 4+)
-# - ocaml, disabled because it fails to install properly
-#
--- End diff --
Recommend adding that php is disabled because we require 5.6 and Trusty
comes with 5.5.9, and comment out the PHP lines, but not delete the whole thing.
> require php ^5.6 || ^7.0
> ------------------------
>
> Key: THRIFT-4438
> URL: https://issues.apache.org/jira/browse/THRIFT-4438
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Affects Versions: 0.11.0
> Reporter: RobberPhex
> Priority: Major
>
> We can remove php5.3~php5.5 support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
