[
https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327189#comment-16327189
]
ASF GitHub Bot commented on THRIFT-4438:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1451#discussion_r161777313
--- Diff: composer.json ---
@@ -16,12 +16,12 @@
"issues": "https://issues.apache.org/jira/browse/THRIFT";
},
"require": {
- "php": ">=5.3.0"
+ "php": "^5.6 || ^7.0"
--- End diff --
Just looking at the changes here for dropping php 5.3 through 5.5, what's
the benefit? No php code actually changed to take advantage of this, so I'm
not sure I see a reason to do it?
> require php ^5.6 || ^7.0
> ------------------------
>
> Key: THRIFT-4438
> URL: https://issues.apache.org/jira/browse/THRIFT-4438
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Affects Versions: 0.11.0
> Reporter: RobberPhex
> Priority: Major
>
> We can remove php5.3~php5.5 support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
