Github user RobberPhex commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1484#discussion_r164633628
  
    --- Diff: lib/php/lib/Factory/TStringFuncFactory.php ---
    @@ -21,8 +21,9 @@
     
     namespace Thrift\Factory;
     
    -use Thrift\StringFunc\Mbstring;
     use Thrift\StringFunc\Core;
    +use Thrift\StringFunc\Mbstring;
    --- End diff --
    
    I sorted use alphabetically, is it unnecessary? Am I expected that change 
it back?


---

Reply via email to