[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

[RobberPhex]

Github user RobberPhex commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1484#discussion_r164633860
  
    --- Diff: lib/php/lib/Transport/TBufferedTransport.php ---
    @@ -22,6 +22,7 @@
     
     namespace Thrift\Transport;
     
    +use Thrift\Exception\TTransportException;
    --- End diff --
    
    some function has doc comment `@throws TTransportException`, No one (and 
IDE) knows which TTransportException, so I think we should add use stmt.
    
    Or, We always use full classname at doc comment, is it?


---