[GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context

[dcelasun]

Github user dcelasun commented on the issue:

    https://github.com/apache/thrift/pull/1459
  
    It would be nice to add a client test using e.g `context.WithTimeout()`. 
Something like:
    
    - In the handler function, sleep for 100ms before returning
    - In the client, call the RPC with 
`context.WithTimeout(context.Background(), 50*time.Millisecond)`
    - Check if `ctx.Err() == context.Canceled`
    
    Otherwise LGTM.


---