[ 
https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387984#comment-16387984
 ] 

ASF GitHub Bot commented on THRIFT-4489:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1491
  
    The presence of "--domain-socket" to the client or server implies uds.  
This needs to be fixed, and domain needs to be moved from haskell to nodejs, 
and the cross tests that are failing (many) in the ubuntu-artful docker image 
need to be investigated.  For example it is likely expected for the 
"http-domain" subset of tests to fail given the http-ip ones fail already, 
however in one test I found that the call to fs.unlinkSync(path)  [server.js] 
failed because the domain socket doesn't exist before the test begins, and this 
call throws an exception, causing it to fail.


> Unix domain socket support for NodeJS client
> --------------------------------------------
>
>                 Key: THRIFT-4489
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4489
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>    Affects Versions: 0.11.0
>            Reporter: Daniel Shih
>            Assignee: James E. King, III
>            Priority: Major
>
> I would like to use Unix domain sockets for NodeJS client,
> Here is the proposed PR: https://github.com/apache/thrift/pull/1491



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to