[ 
https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404221#comment-16404221
 ] 

ASF GitHub Bot commented on THRIFT-4489:
----------------------------------------

Github user danielhtshih commented on the issue:

    https://github.com/apache/thrift/pull/1491
  
    I believe the unexpected failures from the latest run is not related to my 
changes for nodejs.
    
    Maybe it needs another merge from master branch? 
    ```
    
===============================================================================
    Following 14 tests were expected to cleanly succeed but needed retry:
    
===============================================================================
    server-client:          protocol:         transport:               result:
    nodejs-nodejs           json              buffered-domain          flaky(1 
retry)
    nodejs-cpp              json              buffered-ip-ssl          flaky(3 
retries)
    hs-csharp               json              framed-ip                flaky(2 
retries)
    cpp-cpp                 multic            framed-ip-ssl            flaky(2 
retries)
    cpp-cpp                 multij-json       http-ip-ssl              flaky(1 
retry)
    cpp-cpp                 multij-json       framed-ip-ssl            flaky(1 
retry)
    cpp-cpp                 multih            http-ip-ssl              flaky(1 
retry)
    cpp-cpp                 multih-header     http-ip-ssl              flaky(2 
retries)
    cpp-cpp                 multih-header     buffered-ip-ssl          flaky(2 
retries)
    cpp-cpp                 multic-compact    http-ip-ssl              flaky(1 
retry)
    cpp-cpp                 multic-compact    buffered-ip-ssl          flaky(3 
retries)
    cpp-cpp                 multij-json       http-ip-ssl              flaky(1 
retry)
    cpp-cpp                 multij-json       buffered-ip-ssl          flaky(1 
retry)
    cpp-cpp                 multij            buffered-ip-ssl          flaky(2 
retries)
    
===============================================================================
    *** Following 1 failures were unexpected ***:
    If it is introduced by you, please fix it before submitting the code.
    
===============================================================================
    server-client:          protocol:         transport:               result:
    cpp-cpp                 multij-json       buffered-ip-ssl          
failure(64)
    
===============================================================================
    ```


> Unix domain socket support for NodeJS client
> --------------------------------------------
>
>                 Key: THRIFT-4489
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4489
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>    Affects Versions: 0.11.0
>            Reporter: Daniel Shih
>            Assignee: James E. King, III
>            Priority: Major
>
> I would like to use Unix domain sockets for NodeJS client,
> Here is the proposed PR: https://github.com/apache/thrift/pull/1491



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to