[
https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406228#comment-16406228
]
ASF GitHub Bot commented on THRIFT-3560:
----------------------------------------
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/798
I am okay making this change for 0.12.0; if you can rebase, squash, and fix
up the issues and force push, and if there are any other methods that need the
same const correctness, let's do those too.
> C++ TTransport::isOpen() and TTransport::getOrigin() should be const member
> functions
> -------------------------------------------------------------------------------------
>
> Key: THRIFT-3560
> URL: https://issues.apache.org/jira/browse/THRIFT-3560
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.3, 0.10.0, 1.0
> Reporter: Sebastian Zenker
> Priority: Minor
> Labels: easyfix
>
> ... as they should not alter the state of TTransport. Also peek() should be
> const in my opinion, but this requires some more refactoring.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
