ASF GitHub Bot commented on THRIFT-3560:

jeking3 commented on issue #798: THRIFT-3560: C++: declared 
TTransport::isOpen() and TTransport::getOrigin() as const member functions
URL: https://github.com/apache/thrift/pull/798#issuecomment-379247744
   Closing due to 2 years of inaction.  Seems like a good idea but it is 
incomplete.  If we're going to const correct things we should do it with one 
breaking change.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> C++ TTransport::isOpen() and TTransport::getOrigin() should be const member 
> functions
> -------------------------------------------------------------------------------------
>                 Key: THRIFT-3560
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3560
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.9.3, 0.10.0, 1.0
>            Reporter: Sebastian Zenker
>            Priority: Minor
>              Labels: easyfix
> ... as they should not alter the state of TTransport. Also peek() should be 
> const in my opinion, but this requires some more refactoring.

This message was sent by Atlassian JIRA

Reply via email to