[
https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748046#comment-16748046
]
Sebastian Zenker commented on THRIFT-3560:
------------------------------------------
Should I also add the override keyword to all those virtual functions as you
are now enforcing C++11?
> C++ TTransport::isOpen() and TTransport::getOrigin() should be const member
> functions
> -------------------------------------------------------------------------------------
>
> Key: THRIFT-3560
> URL: https://issues.apache.org/jira/browse/THRIFT-3560
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.3, 0.10.0
> Reporter: Sebastian Zenker
> Priority: Minor
> Labels: easyfix
> Time Spent: 10m
> Remaining Estimate: 0h
>
> ... as they should not alter the state of TTransport. Also peek() should be
> const in my opinion, but this requires some more refactoring.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
