[
https://issues.apache.org/jira/browse/THRIFT-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515125#comment-16515125
]
ASF GitHub Bot commented on THRIFT-4586:
----------------------------------------
jeking3 commented on issue #1564: THRIFT-4586: Correctly generates NSString
with copy instead of strong - Cocoa
URL: https://github.com/apache/thrift/pull/1564#issuecomment-397889896
I'll need someone who knows the language to code review. and we can ignore
the CI because we don't currently test cocoa in CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Thrift generated strings for Cocoa/Objective-C should use copy not strong.
> --------------------------------------------------------------------------
>
> Key: THRIFT-4586
> URL: https://issues.apache.org/jira/browse/THRIFT-4586
> Project: Thrift
> Issue Type: Bug
> Reporter: Kevin Carbone
> Priority: Major
>
> Thrift generated strings for Cocoa/Objective-C should use copy not strong.
> Currently all strings use strong. This is dangerous if one assigns a strong
> reference to an analytics object.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
