[
https://issues.apache.org/jira/browse/THRIFT-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524166#comment-16524166
]
ASF GitHub Bot commented on THRIFT-4586:
----------------------------------------
CarbonComputed edited a comment on issue #1564: THRIFT-4586: Correctly
generates NSString with copy instead of strong - Cocoa
URL: https://github.com/apache/thrift/pull/1564#issuecomment-400444669
@Jens-G Yeah I posted the PR on behalf of Reddit. We use it on iOS and I
noticed that the generated NSStrings are strong which is something you don't
want to do. Lets say a developer sets a string on the generated class, if that
string is modified, youre directly modifiying the reference to that string,
which is something you don't want to do and can cause unexpected behavior. I
can add some iOS devs, but I'm not sure who to add that has the unique Thrift
knowledge here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Thrift generated strings for Cocoa/Objective-C should use copy not strong.
> --------------------------------------------------------------------------
>
> Key: THRIFT-4586
> URL: https://issues.apache.org/jira/browse/THRIFT-4586
> Project: Thrift
> Issue Type: Bug
> Reporter: Kevin Carbone
> Priority: Major
>
> Thrift generated strings for Cocoa/Objective-C should use copy not strong.
> Currently all strings use strong. This is dangerous if one assigns a strong
> reference to an analytics object.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
