[
https://issues.apache.org/jira/browse/THRIFT-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592774#comment-16592774
]
ASF GitHub Bot commented on THRIFT-4625:
----------------------------------------
bforbis commented on a change in pull request #1584: THRIFT-4625: Use let/const
variable decorators in ES6 Javascript
URL: https://github.com/apache/thrift/pull/1584#discussion_r212814185
##########
File path: compiler/cpp/src/thrift/generate/t_js_generator.cc
##########
@@ -1134,7 +1156,12 @@ void
t_js_generator::generate_process_function(t_service* tservice, t_function*
f_service_ << indent() << "if (this._handler." << tfunction->get_name()
<< ".length === " << fields.size() << ") {" << endl;
indent_up();
- indent(f_service_) << "Q.fcall(this._handler." << tfunction->get_name() <<
".bind(this._handler)";
Review comment:
This is also fixing a bug in the es6 compiler which references the `Q`
package without importing it. ES6 should use the native `Promise.resolve`
instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> let / const variable decorators for es6 compiler
> ------------------------------------------------
>
> Key: THRIFT-4625
> URL: https://issues.apache.org/jira/browse/THRIFT-4625
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Compiler, Node.js - Compiler
> Reporter: Brian Forbis
> Priority: Minor
>
> With support for the ES6 compiler, variables should be scoped using the ES6
> *let* and *const* variable decorators to define variable scoping and
> read/write behavior.
> This brings the generated code into compliance with the
> [no-var|https://eslint.org/docs/rules/no-var] eslint rule.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
