[
https://issues.apache.org/jira/browse/THRIFT-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592982#comment-16592982
]
ASF GitHub Bot commented on THRIFT-4625:
----------------------------------------
bforbis commented on issue #1584: THRIFT-4625: Use let/const variable
decorators in ES6 Javascript
URL: https://github.com/apache/thrift/pull/1584#issuecomment-416056276
I _think_ this is breaking the normal js/es6 tests (without node), but I'm
less familiar with how those are set up. Probably the tests need to be set up
with a babel transpiler rather than just using the `es6-promise` polyfill.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> let / const variable decorators for es6 compiler
> ------------------------------------------------
>
> Key: THRIFT-4625
> URL: https://issues.apache.org/jira/browse/THRIFT-4625
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Compiler, Node.js - Compiler
> Reporter: Brian Forbis
> Priority: Minor
>
> With support for the ES6 compiler, variables should be scoped using the ES6
> *let* and *const* variable decorators to define variable scoping and
> read/write behavior.
> This brings the generated code into compliance with the
> [no-var|https://eslint.org/docs/rules/no-var] eslint rule.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
