[ 
https://issues.apache.org/jira/browse/THRIFT-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613986#comment-16613986
 ] 

Jens Geyer commented on THRIFT-4499:
------------------------------------

[~ngangam]: The docs are over here 
[http://thrift.apache.org/docs/HowToContribute]

Although we prefer PRs via Github, there has been no officcial decision to not 
accept patch files anymore, so that should be fine.

 

> Remove Magic Number In TFIleTransport
> -------------------------------------
>
>                 Key: THRIFT-4499
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4499
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>    Affects Versions: 0.11.0
>            Reporter: BELUGA BEHR
>            Priority: Trivial
>         Attachments: THRIFT-4499.1.patch
>
>
> Here, the buffer is hard-coded to 8192 (which matches the default value on 
> most JDK implementations). You may wish to remove this magic number and let 
> the JDK decide the size.
> https://github.com/apache/thrift/blob/19baeefd8c38d62085891d7956349601f79448b3/lib/java/src/org/apache/thrift/transport/TFileTransport.java#L369



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to