[
https://issues.apache.org/jira/browse/THRIFT-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640082#comment-16640082
]
ASF GitHub Bot commented on THRIFT-4499:
----------------------------------------
nrg4878 opened a new pull request #1607: THRIFT-4499: Remove Magic Number In
TFIleTransport (BELUGA BEHR)
URL: https://github.com/apache/thrift/pull/1607
Some helpful tips for a successful Apache Thrift PR:
* Did you test your changes locally or using CI in your fork?
* Is the Apache Jira THRIFT ticket identifier in the PR title?
* Is the Apache Jira THRIFT ticket identifier in the commit message?
* Did you squash your changes to a single commit?
* Are these changes backwards compatible? (please say so in PR description)
* Do you need to update the language-specific README?
Example ideal pull request title:
THRIFT-9999: an example pull request title
Example ideal commit message:
THRIFT-9999: [summary of fix, one line if possible]
Client: [language(s) affected, comma separated, use lib/ directory
names please]
For more information about committing, see CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove Magic Number In TFIleTransport
> -------------------------------------
>
> Key: THRIFT-4499
> URL: https://issues.apache.org/jira/browse/THRIFT-4499
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.11.0
> Reporter: BELUGA BEHR
> Priority: Trivial
> Attachments: THRIFT-4499.1.patch
>
>
> Here, the buffer is hard-coded to 8192 (which matches the default value on
> most JDK implementations). You may wish to remove this magic number and let
> the JDK decide the size.
> https://github.com/apache/thrift/blob/19baeefd8c38d62085891d7956349601f79448b3/lib/java/src/org/apache/thrift/transport/TFileTransport.java#L369
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
