[
https://issues.apache.org/jira/browse/THRIFT-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625895#comment-16625895
]
ASF GitHub Bot commented on THRIFT-4625:
----------------------------------------
bforbis commented on issue #1584: THRIFT-4625: Use let/const variable
decorators in ES6 Javascript
URL: https://github.com/apache/thrift/pull/1584#issuecomment-423993894
Pinning the dart versions to 1.x in the Dockerfile seemed to help get the
build to pass. There's one more build failure for Dlang on xenial, which I am
unsure about. Looks to be that the tests hang when I run it locally.
Anyway, I think this PR should be ready for re-review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> let / const variable decorators for es6 compiler
> ------------------------------------------------
>
> Key: THRIFT-4625
> URL: https://issues.apache.org/jira/browse/THRIFT-4625
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Compiler, Node.js - Compiler
> Reporter: Brian Forbis
> Priority: Minor
>
> With support for the ES6 compiler, variables should be scoped using the ES6
> *let* and *const* variable decorators to define variable scoping and
> read/write behavior.
> This brings the generated code into compliance with the
> [no-var|https://eslint.org/docs/rules/no-var] eslint rule.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
