[
https://issues.apache.org/jira/browse/THRIFT-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630923#comment-16630923
]
ASF GitHub Bot commented on THRIFT-4639:
----------------------------------------
bforbis edited a comment on issue #1597: THRIFT-4639: Use correct sequence
number for multiplexed protocol
URL: https://github.com/apache/thrift/pull/1597#issuecomment-425210116
To run the node tests, follow the instructions in the [docker
README](https://github.com/apache/thrift/tree/master/build/docker) for creating
your test image.
You can then either run the full test suite with `autotools.sh`, or if you
want to just run the nodeJS tests you should be able to run `make check` within
the node lib directory. Alternatively, if you understand how grunt files work
you can just use that directly.
I've got an open PR in #1584 which is doing a sizeable refactor, so our
changes may conflict
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Sequence numbering for multiplexed protocol broken
> --------------------------------------------------
>
> Key: THRIFT-4639
> URL: https://issues.apache.org/jira/browse/THRIFT-4639
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.11.0
> Reporter: PH Lundblom
> Priority: Blocker
>
> Handling of client sequence numbering for multiplexed protocol is broken.
> Current implementation uses client internal variable "seqid" which should be
> "_seqid"
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
