[
https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659553#comment-16659553
]
ASF GitHub Bot commented on THRIFT-4654:
----------------------------------------
ericklaus-wf commented on a change in pull request #1617: THRIFT-4654 Minor
fixes for dart 1 & 2 compatibility (backwards compatible)
URL: https://github.com/apache/thrift/pull/1617#discussion_r227045903
##########
File path: lib/dart/pubspec.yaml
##########
@@ -24,20 +24,15 @@ homepage: http://thrift.apache.org
documentation: http://thrift.apache.org
environment:
- sdk: ">=1.13.0 <2.0.0"
+ sdk: '>=1.24.3<3.0.0'
Review comment:
It doesn't matter to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Thrift Dart port is not compatible with Dart 2
> ----------------------------------------------
>
> Key: THRIFT-4654
> URL: https://issues.apache.org/jira/browse/THRIFT-4654
> Project: Thrift
> Issue Type: Improvement
> Components: Dart - Library
> Environment: Any OS, under Dart 2+
> Reporter: Rob Becker
> Assignee: James E. King III
> Priority: Minor
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires
> opting in via a setting in the pubspec.yaml and the code needs to update the
> use of all caps constant names to the new camel case names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
