[
https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659776#comment-16659776
]
ASF GitHub Bot commented on THRIFT-4654:
----------------------------------------
jeking3 commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2
compatibility (backwards compatible)
URL: https://github.com/apache/thrift/pull/1617#issuecomment-432016870
```
make -C dart precross
make[2]: Entering directory '/thrift/src/test/dart'
/thrift/src/compiler/cpp/thrift --gen dart ../ThriftTest.thrift
[WARNING:/thrift/src/test/ThriftTest.thrift:45] No generator named 'noexist'
could be found!
[WARNING:/thrift/src/test/ThriftTest.thrift:47] cpp generator does not
accept 'noexist' as sub-namespace!
cd gen-dart/thrift_test; /usr/lib/dart/bin/pub get
[[7m [27m[90m................[0m] \ loadDep:ws: [7msill[0m
[35minstall[0m loadAllDepsIntoIdealTree[0m[K
[[7m [27m[90m..............[0m] \ loadDep:wordwrap: [7msill[0m
[35minstall[0m loadAllDepsIntoIdealTree[0m[K
[[7m [27m[90m..............[0m] \ loadDep:underscore: [7msill[0m
[35minstall[0m loadAllDepsIntoIdealTre[0m[K
[[7m [27m[90m.............[0m] \ loadDep:xtend: [7msill[0m
[35minstall[0m loadAllDepsIntoIdealTree[0m[K
[[7m [27m[90m.............[0m] \ loadDep:strip-json-comments:
[7msill[0m [35minstall[0m loadAllDepsInt[0m[K
[[7m [27m[90m...........[0m] | diffTrees: [7msill[0m
[35minstall[0m generateActionsToTake[0m[K
Resolving dependencies... [[7m [27m[90m...........[0m] -
postinstall: [7msill[0m [35minstall[0m executeActions[0m[K
The current Dart SDK version is 2.0.0.
Because thrift_test requires SDK version ^1.12.0, version solving failed.
Makefile:626: recipe for target 'pub-get-gen' failed
make[2]: *** [pub-get-gen] Error 1
make[2]: Leaving directory '/thrift/src/test/dart'
Makefile:911: recipe for target 'precross-dart' failed
make[1]: *** [precross-dart] Error 2
make[1]: Leaving directory '/thrift/src/test'
Makefile:1094: recipe for target 'precross-test' failed
make: *** [precross-test] Error 2
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Thrift Dart port is not compatible with Dart 2
> ----------------------------------------------
>
> Key: THRIFT-4654
> URL: https://issues.apache.org/jira/browse/THRIFT-4654
> Project: Thrift
> Issue Type: Improvement
> Components: Dart - Library
> Environment: Any OS, under Dart 2+
> Reporter: Rob Becker
> Assignee: James E. King III
> Priority: Minor
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires
> opting in via a setting in the pubspec.yaml and the code needs to update the
> use of all caps constant names to the new camel case names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
