[
https://issues.apache.org/jira/browse/THRIFT-5010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975441#comment-16975441
]
Jens Geyer edited comment on THRIFT-5010 at 11/15/19 10:36 PM:
---------------------------------------------------------------
If it is wrong, we need a test case and should mark it as "bug".
If it works and "improvement" is correct, then claim is wrong ("should do X")
because it obvuiously does that already.
was (Author: jensg):
Testcase?
> NetStd: TFramedTransport - bigEndianConversion incorrect
> --------------------------------------------------------
>
> Key: THRIFT-5010
> URL: https://issues.apache.org/jira/browse/THRIFT-5010
> Project: Thrift
> Issue Type: Improvement
> Components: netstd - Library
> Affects Versions: 0.13.0
> Reporter: Edward Zhuravlov
> Priority: Major
> Labels: features
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Conversion should be based on processor architecture. See System.BitConverter
> class:
> [https://docs.microsoft.com/en-us/dotnet/api/system.bitconverter?view=netstandard-2.0]
> Recomended use BinaryPrimitives.WriteInt32BigEndian/ReadInt32BigEndian class
> from nuget System.Memory by Microsoft for NetStandard 2.0.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
