[
https://issues.apache.org/jira/browse/THRIFT-5010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976038#comment-16976038
]
Jens Geyer edited comment on THRIFT-5010 at 11/17/19 2:17 PM:
--------------------------------------------------------------
(1) What about the binary transport methods? I think we should get that done
too.
(2) Could you prepare a pull request?
(3) Still unclear if this does not work under certain conditions (bug) or if it
is an improvement.
was (Author: jensg):
Could you prepare a pull request?
> NetStd: TFramedTransport - bigEndianConversion incorrect
> --------------------------------------------------------
>
> Key: THRIFT-5010
> URL: https://issues.apache.org/jira/browse/THRIFT-5010
> Project: Thrift
> Issue Type: Improvement
> Components: netstd - Library
> Affects Versions: 0.13.0
> Reporter: Edward Zhuravlov
> Priority: Major
> Labels: features
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Conversion -should be- _from/to TCP protocol format (always big-Endian) to
> execution engine_ based on processor architecture. See System.BitConverter
> class ():
> [https://docs.microsoft.com/en-us/dotnet/api/system.bitconverter?view=netstandard-2.0]
> ??The endianness of an architecture is indicated by the
> [IsLittleEndian|https://docs.microsoft.com/en-us/dotnet/api/system.bitconverter.islittleendian?view=netframework-4.8]
> property, which returns {{true}} on little-endian systems and {{false}} on
> big-endian systems. On little-endian systems, lower-order bytes precede
> higher-order bytes. On big-endian system, higher-order bytes precede
> lower-order bytes. ??
> Recomended use BinaryPrimitives.WriteInt32BigEndian/ReadInt32BigEndian class
> from nuget System.Memory by Microsoft for NetStandard 2.0.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
