[
https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078408#comment-17078408
]
Jano Svitok commented on THRIFT-5109:
-------------------------------------
I suspect that boost is not needed anymore in compiler/cpp/test. I will not
have time to check it, maybe you could while you're improving cmake.
Boost was needed until compiler plugins were removed.
{code}
compiler/cpp/test/CMakeLists.txt | 6 ------
compiler/cpp/test/Makefile.am | 3 +--
compiler/cpp/test/bincat.sh | 3 ---
3 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/compiler/cpp/test/CMakeLists.txt b/compiler/cpp/test/CMakeLists.txt
index 2bc7e9e69..20e8f1bbf 100644
--- a/compiler/cpp/test/CMakeLists.txt
+++ b/compiler/cpp/test/CMakeLists.txt
@@ -17,12 +17,6 @@
# under the License.
#
-# Unit tests for the compiler still require boost
-include(BoostMacros)
-REQUIRE_BOOST_HEADERS()
-set(BOOST_COMPONENTS unit_test_framework)
-REQUIRE_BOOST_LIBRARIES(BOOST_COMPONENTS)
-
file(GLOB KEYWORD_SAMPLES
"${CMAKE_CURRENT_SOURCE_DIR}/keyword-samples/*.thrift")
foreach(LANG ${thrift_compiler_LANGS})
foreach(SAMPLE ${KEYWORD_SAMPLES})
diff --git a/compiler/cpp/test/Makefile.am b/compiler/cpp/test/Makefile.am
index 801f9d85e..10efd0737 100644
--- a/compiler/cpp/test/Makefile.am
+++ b/compiler/cpp/test/Makefile.am
@@ -23,6 +23,5 @@
AUTOMAKE_OPTIONS = subdir-objects serial-tests nostdinc
-AM_CPPFLAGS = $(BOOST_CPPFLAGS) -I$(top_srcdir)/compiler/cpp/src
-AM_LDFLAGS = $(BOOST_LDFLAGS)
+AM_CPPFLAGS = -I$(top_srcdir)/compiler/cpp/src
AM_CXXFLAGS = -Wall -Wextra -pedantic
diff --git a/compiler/cpp/test/bincat.sh b/compiler/cpp/test/bincat.sh
deleted file mode 100755
index c7f90785e..000000000
--- a/compiler/cpp/test/bincat.sh
+++ /dev/null
@@ -1,3 +0,0 @@
-#!/bin/bash
-
-exec /bin/cat
{code}
> Misc CMake improvements
> -----------------------
>
> Key: THRIFT-5109
> URL: https://issues.apache.org/jira/browse/THRIFT-5109
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
> Reporter: Jens Geyer
> Assignee: Mario Emmenlauer
> Priority: Major
> Fix For: 0.14.0
>
>
> * compiler/cpp/CMakeLists.txt: Install compiler after build, like automake
> does
> * Added NodeJS to cmake build
> * Added Javascript to cmake build
> * build/cmake/DefineInstallationPaths.cmake: fixed the library path
> * build/cmake/ThriftMacros.cmake: do not enforce debug suffix 'd'
> * lib/java/CMakeLists.txt: allow to override JAVA_INSTALL_DIR
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
