[
https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083302#comment-17083302
]
Mario Emmenlauer commented on THRIFT-5109:
------------------------------------------
> Would [this
>change|https://github.com/apache/thrift/pull/2094/files#diff-9a86cb41bfe9d6fec8e92b71bd8e6b8bL326]
> explain the problem?
Thanks for the help, but no.
To motivate this change: I removed the automatic call to jsdoc because I added
instead an explicit call to jsdoc in CMakeLists.txt (and I wanted to avoid
duplicates). This was part of a test if the automatic jsdoc may not be
executed. However the docs are not built in AppVeyor either way. After the
issue is resolved, I plan to re-add the automatic call to jsdoc and remove the
explicit call again.
> Misc CMake improvements
> -----------------------
>
> Key: THRIFT-5109
> URL: https://issues.apache.org/jira/browse/THRIFT-5109
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
> Reporter: Jens Geyer
> Assignee: Mario Emmenlauer
> Priority: Major
> Fix For: 0.14.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> * compiler/cpp/CMakeLists.txt: Install compiler after build, like automake
> does
> * Added NodeJS to cmake build
> * Added Javascript to cmake build
> * build/cmake/DefineInstallationPaths.cmake: fixed the library path
> * build/cmake/ThriftMacros.cmake: do not enforce debug suffix 'd'
> * lib/java/CMakeLists.txt: allow to override JAVA_INSTALL_DIR
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
