[ 
https://issues.apache.org/jira/browse/THRIFT-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818007#comment-17818007
 ] 

Paul Wilkinson commented on THRIFT-5712:
----------------------------------------

Hi all, I have finished everything except for one last test, the 
TFramedTransport test.

I have broken out the code into a simple test below. Basically I have to add 
the "..setReadBuffer(readBuffer);" in order for the transport to have a 
readIterator. But this should not be required, and it only gets me a bit 
further. I have read a lot of code but still can't figure out when 
TBufferedTransport._readIterator should be initialized. 

Can anybody give me some guidance here?
{quote} 
void main() async {
late FakeReadOnlySocket socket = FakeReadOnlySocket();
var readBuffer = Uint8List(128);
late TClientSocketTransport socketTransport = TClientSocketTransport(socket)
..setReadBuffer(readBuffer);
late TFramedTransport transport = TFramedTransport(socketTransport);

Uint8List buffer = Uint8List.fromList([0x00, 0x00, 0x00, 0x06]);
transport.write(buffer, 0, buffer.length);
var readBytes = await transport.read(readBuffer, 0, readBuffer.lengthInBytes);
// expect(readBytes, 0);
}{quote}
 

> Add Dart 3 compatibility
> ------------------------
>
>                 Key: THRIFT-5712
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5712
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Dart - Compiler
>    Affects Versions: 0.18.1
>            Reporter: Vlad Koronnov
>            Priority: Major
>
> Dart project generated by thrift has constraints in pubspec.yaml
>  
> {code:java}
> name: dart_client
> version: 0.0.1
> description: Autogenerated by Thrift Compiler
> environment:
>   sdk: '>=2.12.0 <3.0.0' {code}
>  
>  
> And generated code uses uninitialized variables, which can't be used with 
> sound null safety, required by Dart 3.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to