kpumuk opened a new pull request, #3309:
URL: https://github.com/apache/thrift/pull/3309
<!-- Explain the changes in the pull request below: -->
Since Travis migration, static code analysis job was never migrated to
GitHub actions. I am looking to bring it over (and add Rubocop there for Ruby
library), but need to address the offences first.
Old script used to run the following tests:
* `cppcheck` for cpp and c_glib
* `flake8` for Python (PR is coming up)
* `phpcs` for PHP
This PR fixes PHP issues:
```
FILE: lib/php/test/Unit/Lib/Protocol/TMultiplexedProtocolTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
84 | ERROR | [x] Function closing brace must go on the next line following
the
| | body; found 1 blank lines before brace
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: lib/php/lib/ClassLoader/ThriftClassLoader.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
105 | ERROR | [x] Expected 0 spaces after opening bracket; newline found
189 | ERROR | [x] Expected 0 spaces after opening bracket; newline found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: lib/php/test/Unit/Lib/Transport/TSSLSocketTest.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
163 | ERROR | [x] Line indented incorrectly; expected at least 20 spaces,
| | found 17
164 | ERROR | [x] Line indented incorrectly; expected at least 24 spaces,
| | found 21
165 | ERROR | [x] Line indented incorrectly; expected at least 24 spaces,
| | found 21
167 | ERROR | [x] Line indented incorrectly; expected at least 24 spaces,
| | found 21
168 | ERROR | [x] Line indented incorrectly; expected 20 spaces, found 17
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: lib/php/lib/Transport/TCurlClient.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
297 | WARNING | Line exceeds 120 characters; contains 142 characters
----------------------------------------------------------------------
FILE: lib/php/test/Unit/Lib/Transport/TSocketTest.php
--------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------------
175 | ERROR | [x] Line indented incorrectly; expected at least 20 spaces,
| | found 17
182 | ERROR | [x] Line indented incorrectly; expected at least 24 spaces,
| | found 21
183 | ERROR | [x] Line indented incorrectly; expected at least 24 spaces,
| | found 21
185 | ERROR | [x] Line indented incorrectly; expected at least 24 spaces,
| | found 21
186 | ERROR | [x] Line indented incorrectly; expected 20 spaces, found 17
296 | ERROR | [ ] Method name "TSocketTest::testOpen_THRIFT_5132" is not in
| | camel caps format
340 | ERROR | [ ] Method name "TSocketTest::open_THRIFT_5132_DataProvider"
is
| | not in camel caps format
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: lib/php/test/Unit/Lib/Transport/TCurlClientTest.php
--------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
124 | ERROR | [ ] Method name "TCurlClientTest::testReadAll_THRIFT_4656" is
| | not in camel caps format
193 | ERROR | [x] Line indented incorrectly; expected at least 24 spaces,
| | found 21
194 | ERROR | [x] Line indented incorrectly; expected at least 28 spaces,
| | found 25
195 | ERROR | [x] Multi-line function call not indented correctly; expected
29
| | spaces but found 33
196 | ERROR | [x] Multi-line function call not indented correctly; expected
25
| | spaces but found 29
196 | ERROR | [x] Line indented incorrectly; expected at least 31 spaces,
| | found 29
197 | ERROR | [x] Line indented incorrectly; expected 24 spaces, found 21
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 2.79 secs; Memory: 6MB
```
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but
preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
