kpumuk opened a new pull request, #3310:
URL: https://github.com/apache/thrift/pull/3310
<!-- Explain the changes in the pull request below: -->
Since Travis migration, static code analysis job was never migrated to
GitHub actions. I am looking to bring it over (and add Rubocop there for Ruby
library), but need to address the offences first.
Old script used to run the following tests:
* `cppcheck` for cpp and c_glib
* `flake8` for Python (PR is coming up)
* `phpcs` for PHP
This PR fixes Python issues:
```
./lib/py/src/TTornado.py:93:8: E111 indentation is not a multiple of 4
./lib/py/src/TTornado.py:94:12: E111 indentation is not a multiple of 4
./lib/py/src/TTornado.py:95:8: E111 indentation is not a multiple of 4
./lib/py/src/protocol/TJSONProtocol.py:24:1: F401 'sys' imported but unused
./lib/py/src/protocol/TProtocol.py:23:1: F401 'sys' imported but unused
./lib/py/src/transport/THttpClient.py:105:27: F821 undefined name 'six'
./lib/py/src/transport/TSSLSocket.py:31:1: E731 do not assign a lambda
expression, use a def
./lib/py/src/transport/TSSLSocket.py:359:15: E275 missing whitespace after
keyword
./lib/py/src/transport/sslcompat.py:100:13: E731 do not assign a lambda
expression, use a def
./lib/py/test/fuzz/fuzz_common.py:25:1: E302 expected 2 blank lines, found 1
./lib/py/test/fuzz/fuzz_common.py:51:1: E305 expected 2 blank lines after
class or function definition, found 1
./lib/py/test/fuzz/fuzz_common.py:57:1: E302 expected 2 blank lines, found 1
./lib/py/test/fuzz/fuzz_common.py:60:1: W293 blank line contains whitespace
./lib/py/test/fuzz/fuzz_common.py:63:1: W293 blank line contains whitespace
./lib/py/test/fuzz/fuzz_common.py:74:13: F841 local variable 'transport' is
assigned to but never used
./lib/py/test/fuzz/fuzz_common.py:78:13: F841 local variable 'test_instance'
is assigned to but never used
./lib/py/test/fuzz/fuzz_common.py:80:9: F841 local variable 'e' is assigned
to but never used
./lib/py/test/fuzz/fuzz_common.py:86:1: E302 expected 2 blank lines, found 1
./lib/py/test/fuzz/fuzz_common.py:89:1: W293 blank line contains whitespace
./lib/py/test/fuzz/fuzz_common.py:92:1: W293 blank line contains whitespace
./lib/py/test/fuzz/fuzz_common.py:103:13: F841 local variable 'transport' is
assigned to but never used
./lib/py/test/fuzz/fuzz_common.py:117:9: F841 local variable 'e' is assigned
to but never used
./lib/py/test/fuzz/fuzz_common.py:123:1: E302 expected 2 blank lines, found 1
./lib/py/test/fuzz/fuzz_common.py:126:1: W293 blank line contains whitespace
./lib/py/test/fuzz/fuzz_common.py:139:1: W293 blank line contains whitespace
./lib/py/test/fuzz/fuzz_common.py:149:1: W293 blank line contains whitespace
./lib/py/test/fuzz/fuzz_common.py:153:62: W292 no newline at end of file
./lib/py/test/fuzz/fuzz_parse_TBinaryProtocol.py:23:1: E302 expected 2 blank
lines, found 1
./lib/py/test/fuzz/fuzz_parse_TBinaryProtocol.py:26:1: E305 expected 2 blank
lines after class or function definition, found 1
./lib/py/test/fuzz/fuzz_parse_TBinaryProtocolAccelerated.py:23:1: E302
expected 2 blank lines, found 1
./lib/py/test/fuzz/fuzz_parse_TBinaryProtocolAccelerated.py:26:1: E305
expected 2 blank lines after class or function definition, found 1
./lib/py/test/fuzz/fuzz_parse_TBinaryProtocolAccelerated.py:27:11: W291
trailing whitespace
./lib/py/test/fuzz/fuzz_parse_TBinaryProtocolAccelerated.py:27:12: W292 no
newline at end of file
./lib/py/test/fuzz/fuzz_parse_TCompactProtocol.py:23:1: E302 expected 2
blank lines, found 1
./lib/py/test/fuzz/fuzz_parse_TCompactProtocol.py:26:1: E305 expected 2
blank lines after class or function definition, found 1
./lib/py/test/fuzz/fuzz_parse_TCompactProtocol.py:27:11: W291 trailing
whitespace
./lib/py/test/fuzz/fuzz_parse_TCompactProtocol.py:27:12: W292 no newline at
end of file
./lib/py/test/fuzz/fuzz_parse_TCompactProtocolAccelerated.py:23:1: E302
expected 2 blank lines, found 1
./lib/py/test/fuzz/fuzz_parse_TCompactProtocolAccelerated.py:26:1: E305
expected 2 blank lines after class or function definition, found 1
./lib/py/test/fuzz/fuzz_parse_TCompactProtocolAccelerated.py:27:11: W291
trailing whitespace
./lib/py/test/fuzz/fuzz_parse_TCompactProtocolAccelerated.py:27:12: W292 no
newline at end of file
./lib/py/test/fuzz/fuzz_roundtrip_TBinaryProtocol.py:23:1: E302 expected 2
blank lines, found 1
./lib/py/test/fuzz/fuzz_roundtrip_TBinaryProtocol.py:26:1: E305 expected 2
blank lines after class or function definition, found 1
./lib/py/test/fuzz/fuzz_roundtrip_TBinaryProtocolAccelerated.py:23:1: E302
expected 2 blank lines, found 1
./lib/py/test/fuzz/fuzz_roundtrip_TBinaryProtocolAccelerated.py:26:1: E305
expected 2 blank lines after class or function definition, found 1
./lib/py/test/fuzz/fuzz_roundtrip_TBinaryProtocolAccelerated.py:27:11: W291
trailing whitespace
./lib/py/test/fuzz/fuzz_roundtrip_TBinaryProtocolAccelerated.py:27:12: W292
no newline at end of file
./lib/py/test/fuzz/fuzz_roundtrip_TCompactProtocol.py:23:1: E302 expected 2
blank lines, found 1
./lib/py/test/fuzz/fuzz_roundtrip_TCompactProtocol.py:26:1: E305 expected 2
blank lines after class or function definition, found 1
./lib/py/test/fuzz/fuzz_roundtrip_TCompactProtocol.py:27:11: W291 trailing
whitespace
./lib/py/test/fuzz/fuzz_roundtrip_TCompactProtocol.py:27:12: W292 no newline
at end of file
./lib/py/test/fuzz/fuzz_roundtrip_TCompactProtocolAccelerated.py:23:1: E302
expected 2 blank lines, found 1
./lib/py/test/fuzz/fuzz_roundtrip_TCompactProtocolAccelerated.py:26:1: E305
expected 2 blank lines after class or function definition, found 1
./lib/py/test/fuzz/fuzz_roundtrip_TCompactProtocolAccelerated.py:27:11: W291
trailing whitespace
./lib/py/test/fuzz/fuzz_roundtrip_TCompactProtocolAccelerated.py:27:12: W292
no newline at end of file
./lib/py/test/test_socket.py:35:53: E261 at least two spaces before inline
comment
./lib/py/test/test_socket.py:58:27: E261 at least two spaces before inline
comment
./lib/py/test/thrift_TBinaryProtocol.py:269:25: E127 continuation line
over-indented for visual indent
./lib/py/test/thrift_TSerializer.py:34:1: F401 'thrift.transport.TTransport'
imported but unused
./test/crossrunner/run.py:309:48: E231 missing whitespace after ','
./test/crossrunner/run.py:326:40: E231 missing whitespace after ','
./test/py/FastbinaryTest.py:29:1: F401 'os' imported but unused
./test/py/FastbinaryTest.py:30:1: F401 'sys' imported but unused
./test/py/RunClientServer.py:318:61: E231 missing whitespace after ','
./test/py/SerializationTest.py:47:1: F401 'sys' imported but unused
./test/py/TestClient.py:233:9: F841 local variable 'x' is assigned to but
never used
./test/py/TestServer.py:413:5: F811 redefinition of unused 'TException' from
line 31
./test/py/TestTypes.py:26:87: W291 trailing whitespace
./test/py/TestTypes.py:27:1: E302 expected 2 blank lines, found 1
./test/py/TestTypes.py:31:1: E302 expected 2 blank lines, found 1
./test/py/TestTypes.py:60:1: W293 blank line contains whitespace
./test/py/explicit_module/EnumSerializationTest.py:30:1: E302 expected 2
blank lines, found 1
./test/py/explicit_module/EnumSerializationTest.py:31:17: E128 continuation
line under-indented for visual indent
./test/py/explicit_module/EnumSerializationTest.py:32:17: E128 continuation
line under-indented for visual indent
./test/py/explicit_module/EnumSerializationTest.py:37:1: E302 expected 2
blank lines, found 1
./test/py/explicit_module/EnumSerializationTest.py:45:1: E302 expected 2
blank lines, found 1
./test/py/explicit_module/EnumSerializationTest.py:53:1: E302 expected 2
blank lines, found 1
./test/py/explicit_module/EnumSerializationTest.py:61:1: E302 expected 2
blank lines, found 1
./test/py/explicit_module/EnumSerializationTest.py:71:1: E303 too many blank
lines (3)
./test/py/explicit_module/EnumSerializationTest.py:80:56: W292 no newline at
end of file
```
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but
preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
