[
https://issues.apache.org/jira/browse/TIKA-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18039687#comment-18039687
]
Tim Allison commented on TIKA-4251:
-----------------------------------
Y, that makes sense. I _tried_ for most of the morning to get the style-based
approach to work.
I was hoping by commenting out most of this, not much would be modified:
[https://github.com/apache/tika/pull/2395/files#diff-6791038bf8d6ad2ace4dc612d3eca63ad90c3f78ce3d1794d898eb9dc57b6bb0]
I don't _think_ that's how this plugin works, unfortunately...despite what the
llms thought...lol. I think this config just runs whatever the defaults are for
those keys that are commented out, but I could be wrong.
This fixes enums, comments and the license headers:
[https://github.com/apache/tika/pull/2395]
In the commit right before what you're seeing in that PR, I have just the
configuration stuff to get spotless to create that version... just some changes
in tika-parent/*
Let me know what you think and if there are better options.
> [DISCUSS] move to cosium's git-code-format-maven-plugin with
> google-java-format
> -------------------------------------------------------------------------------
>
> Key: TIKA-4251
> URL: https://issues.apache.org/jira/browse/TIKA-4251
> Project: Tika
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Major
>
> I was recently working a bit on incubator-stormcrawler, and I noticed that
> they are using cosium's git-code-format-maven-plugin:
> https://github.com/Cosium/git-code-format-maven-plugin
> I was initially annoyed that I couldn't quickly figure out what I had to fix
> to make the linter happyl, but then I realized there was a magic command:
> {{mvn git-code-format:format-code}} which just fixed the code so that the
> linter passed.
> The one drawback I found is that it does not fix nor does it alert on
> wildcard imports. We could still use checkstyle for that but only have one
> rule for checkstyle.
> The other drawback is that there is not a lot of room for variation from
> google's style. This may actually be a benefit, too, of course.
> I just ran this on {{tika-core}} here:
> https://github.com/apache/tika/tree/google-java-format
> What would you think about making this change for 3.x?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
