[
https://issues.apache.org/jira/browse/TIKA-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18040846#comment-18040846
]
Tim Allison commented on TIKA-4251:
-----------------------------------
Y, makes sense. My concern with option 3 is that I'd still run into checkstyle
complaints.
My goal is to use a linter to automatically fix style issues so that I don't
have to manually go back and fix them. It would save a fairly substantial
amount of time, $ and environmental costs if we can use tooling to fix style
problems. I acknowledge I could do a better job of running checkstyle before
committing, pushing and opening PRs :D
If we as the PMC and dev community decide that we lose too much using general
automatic style fixing (no matter the approach), we can go with option 3 or
option 0 (no change) and return to what we had with checkstyle.
I'm really grateful for your problematic finds, [~tilman], and this discussion.
> [DISCUSS] move to cosium's git-code-format-maven-plugin with
> google-java-format
> -------------------------------------------------------------------------------
>
> Key: TIKA-4251
> URL: https://issues.apache.org/jira/browse/TIKA-4251
> Project: Tika
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Major
> Attachments: tika-app.diff
>
>
> I was recently working a bit on incubator-stormcrawler, and I noticed that
> they are using cosium's git-code-format-maven-plugin:
> https://github.com/Cosium/git-code-format-maven-plugin
> I was initially annoyed that I couldn't quickly figure out what I had to fix
> to make the linter happyl, but then I realized there was a magic command:
> {{mvn git-code-format:format-code}} which just fixed the code so that the
> linter passed.
> The one drawback I found is that it does not fix nor does it alert on
> wildcard imports. We could still use checkstyle for that but only have one
> rule for checkstyle.
> The other drawback is that there is not a lot of room for variation from
> google's style. This may actually be a benefit, too, of course.
> I just ran this on {{tika-core}} here:
> https://github.com/apache/tika/tree/google-java-format
> What would you think about making this change for 3.x?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
