Copilot commented on code in PR #3062:
URL: https://github.com/apache/tika/pull/3062#discussion_r3846007738
##########
tika-core/src/main/java/org/apache/tika/metadata/Audio.java:
##########
@@ -84,6 +84,15 @@ public interface Audio {
*/
Property BITS_PER_SAMPLE =
Property.internalInteger("audio:bits-per-sample");
+ /**
+ * The audio track's four-character codec identifier from the MP4/QuickTime
+ * sample description (e.g. "mp4a" for AAC, "alac", "ac-3"), or the
protection
+ * scheme ("drms"/"enca") for protected streams, where {@link #HAS_DRM} is
also
+ * set. A per-stream value: with several audio tracks it reflects the last
one.
+ * Distinct from {@link XMPDM#AUDIO_COMPRESSOR}, the human-readable codec
name.
Review Comment:
In this Javadoc, “drms”/“enca” are described as a “protection scheme”, but
elsewhere (e.g., HAS_DRM) they’re treated as protected sample entry formats. To
avoid confusion with the actual protection scheme type carried in a `schm` box
(e.g., `cenc`), consider clarifying the terminology here.
##########
tika-core/src/main/java/org/apache/tika/metadata/Video.java:
##########
@@ -37,4 +37,13 @@ public interface Video {
* reflects the last one.
*/
Property BITRATE = Property.internalInteger("video:bitrate");
+
+ /**
+ * The video track's four-character codec identifier from the MP4/QuickTime
+ * sample description (e.g. "avc1" for H.264, "hvc1"/"hev1" for HEVC), or
the
+ * protection scheme ("encv"/"drmi") for protected streams. A per-stream
value:
+ * with several video tracks it reflects the last one. Distinct from
Review Comment:
This Javadoc calls “encv”/“drmi” a “protection scheme”, but the value being
exposed is the sample-entry type fourcc. Using “protected sample entry format”
here would be more precise and avoids conflating it with the scheme type found
elsewhere in the MP4 protection boxes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
