dschmidt commented on PR #3062: URL: https://github.com/apache/tika/pull/3062#issuecomment-5432058044
Thanks, all addressed: 1. Protected entries now report the original codec from `sinf`/`frma`; a bare entry without `sinf` still reports the protected format. Since there was no real sample, the fixtures are synthetic, built per ISO/IEC 14496-12 8.12 and cross-checked against FFmpeg's and GPAC's writers: a FairPlay `drms` (esds + sinf/frma mp4a) and testMP4Video.mp4 with its `avc1` turned into `encv` (sinf before btrt). 2. Kept last-entry-wins, consistent with `audio:bitrate`/`video:bitrate`; it's documented in the javadoc and now guarded by a two-entry fixture (mp4a then ac-3). 3. FourCCs are only exposed when all bytes are printable ASCII, with QuickTime's trailing padding trimmed (`raw `, `rle `). 5. Renamed to `audio:fourcc` / `video:fourcc`. FourCCs aren't MP4-specific (QuickTime, AVI, ...), so no container prefix, but the name now says what the value is. A human-readable codec name would need the esds objectTypeIndication and a mapping table, so I'd keep that for a follow-up. 6. Dropped the cross-reference to `xmpDM:audioCompressor`/`videoCompressor`. 7. Both handlers share `Mp4SampleEntries` for the stsd walk, which now also handles size 0 and largesize entries (unit-tested). 8. Trimmed the test comment, restored the ISO common encryption anchor. Not sure which item 4 was, happy to look if you paste it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
