tballison commented on PR #3531:
URL: https://github.com/apache/tika/pull/3531#issuecomment-6663438447
from my bot:
```
Edge cases
1. Quadratic string building on hostile input (Notebook.java, the "ename",
"evalue" case in readOutputs). Each
repeat of either key does text = text + ": " + part, which copies the
whole string again. Jackson's streaming
parser allows duplicate keys by default. A crafted output with ~100k
ename keys stays far under the 256 MB
document cap but copies terabytes of string data, so the parse runs
until the timeout kills it. Fix: keep only
the first ename and evalue, or join them with a StringBuilder.
2. docs/modules/ROOT/partials/supported-formats.adoc is not regenerated.
It needs an entry for JupyterParser with
application/x-ipynb+json. TikaCLITest compares that file with
tika-app's generated listing and will fail. CI
hasn't caught it because the PR has merge conflicts, so no checks have
run.
Hygiene
- Merge conflicts: CHANGES.txt and using-tika/server/index.adoc conflict,
the same pattern as #3520 and #3526.
- Missing tests: none cover the 256 MB / 64 MB limits (they should produce
a TikaException) or bad base64 in an
image (it should be recorded and skipped).
- Long line: one line added to formats.adoc is about 100 characters.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
