dschmidt commented on PR #3531: URL: https://github.com/apache/tika/pull/3531#issuecomment-6663588052
Thanks, all addressed in the last commit. 1. Quadratic string building: an error output now keeps its first `ename` and `evalue` and joins them once. A test with 100,000 repeated `ename` keys runs in well under a second. 2. `supported-formats.adoc` is regenerated with the `JupyterParser` entry; `testSupportedFormatsPartialIsCurrent` passes. - Merge conflicts: resolved earlier today when merging main. - Tests: the document and string limits are covered on `Notebook.read` (with buffers large enough for Jackson to check them), and bad base64 is recorded and skipped. That test turned up a real gap: `Base64.getMimeDecoder()` silently skips characters that are not base64, so garbage decoded into a broken image. The data is now decoded strictly once whitespace is removed; 18 real notebooks still decode every image without an error. - The long line in `formats.adoc` is rewrapped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
